Fix MVBS metadata propagation for channel/frequency_nominal and swapped dimensions - #1781
Open
KAMALESWAR06 wants to merge 2 commits into
Open
Fix MVBS metadata propagation for channel/frequency_nominal and swapped dimensions#1781KAMALESWAR06 wants to merge 2 commits into
KAMALESWAR06 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several MVBS metadata issues:
• frequency_nominal stored as (ping_time, channel) now reduces correctly to (channel,)
• metadata attached to the primary dimension (dim_0) is dynamically reattached
• works when dimensions are swapped via swap_dims_channel_frequency
• preserves whether metadata was a coord or data_var
• avoids accidental reduction of range-related variables
• removes NaNs introduced by ping_time binning
• aligns metadata using .sel({dim_0: ds_MVBS[dim_0]})
Tests added:
• test_compute_MVBS_preserves_frequency_nominal (1D and 2D cases)
• test_compute_MVBS_preserves_channel_when_dims_swapped
All tests pass except pre-existing sonar-data failures.